Added the inLocalTimeZone parameter to the prepareResponse function. #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…This defaults to false (existing behaviour) so is backwards compatible. When inLocalTimeZone = false, dates are returned in the format: "endDate":"2022-12-22T16:51:30.000Z" When inLocalTimeZone = true, dates are returned in the format: "endDate":"2022-12-22T11:51:30.000-0500" This allows performance improvements, because you don't have to perform further date processing on the values to convert them back into the local time zone. This PR adds the flag as a parameter to getSleepSamples. It can easily be added to other functions as required.
Bear 1682 aggregate heart data
StasDoskalenko
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defaults to false (existing behaviour) so is backwards compatible.
When inLocalTimeZone = false, dates are returned in the format: "endDate":"2022-12-22T16:51:30.000Z" When inLocalTimeZone = true, dates are returned in the format: "endDate":"2022-12-22T11:51:30.000-0500"
This allows performance improvements, because you don't have to perform further date processing on the values to convert them back into the local time zone.
This PR adds the flag as a parameter to getSleepSamples. It can easily be added to other functions as required.