update setup wizard and main ui to accommodate https #2356
Conversation
|
Didn't add anything to final page of setup wizard. Felt the prompt to download and launch was sufficient with the updates I made to the download page, which now looks like: 
@kn0wmad is working on updating the docs so I can update those link paths - will need this before release otherwise will need to add a redirect |
|
Are the addresses not showing on purpose? |
frontend/projects/ui/src/app/pages/apps-routes/app-interfaces/app-interfaces.page.ts
Outdated
Show resolved
Hide resolved
frontend/projects/ui/src/app/services/api/embassy-live-api.service.ts
Outdated
Show resolved
Hide resolved
yes because i was just opening the raw html page in the browser |
| @@ -49,7 +49,7 @@ export class SuccessPage { | |||
| const ret = await this.api.complete() | |||
| if (!this.isKiosk) { | |||
| this.torAddress = ret['tor-address'] | |||
| this.lanAddress = ret['lan-address'].replace('https', 'http') | |||
There was a problem hiding this comment.
do we actually want to leave this as is? @dr-bonez
There was a problem hiding this comment.
I'm not actually sure what this is for
There was a problem hiding this comment.
oh, actually, I understand. Yes, we want to leave it, @MattDHill still wants to encourage http immediately after setup on lan
There was a problem hiding this comment.
this is at the end of the setup wizard. basically, do we want to send them to https or http for first login? i just remembered this wont matter though (the browser wont block) bc they are on the lan, so https is fine, right?
| async ngOnInit() { | ||
| if (location.protocol === 'http:') { | ||
| // see if site is available securely | ||
| const res = await fetch(window.location.href.replace('http', 'https')) | ||
| if (res && res.status === 200) { | ||
| // redirect | ||
| window.location.protocol = 'https:' | ||
| } | ||
| } |
There was a problem hiding this comment.
redirect @dr-bonez
wont work for localhost, but tested setting window.location.protocol = 'https:' when on http of a current live server and it redirects properly
* support http2 alpn handshake * fix protocol name * switch to https for tor * update setup wizard and main ui to accommodate https (#2356) * update setup wizard and main ui to accommodate https * update wording in download doc * fix accidential conversion of tor https for services and allow ws still * redirect to https if available * fix replaces to only search at beginning and ignore localhost when checking for https --------- Co-authored-by: Lucy <12953208+elvece@users.noreply.github.com>
No description provided.