chore: Add tracing for debuging the js procedure slowness #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be extremely useful during our switch from docker to JS |
backend/src/procedure/mod.rs
Outdated
Comment on lines
67
to
75
| tracing::trace!( | ||
| "Procedure execute {} {} - {:?}", | ||
| match self { | ||
| PackageProcedure::Docker(_) => "docker", | ||
| PackageProcedure::Script(_) => "JS", | ||
| }, | ||
| pkg_id, | ||
| name | ||
| ); |
There was a problem hiding this comment.
yeesh this is a lot of visual space for a trace log. Is there any way to make it more innocuous?
I may encourage display instances for Package Procedure and then you can eliminate the case statement and probably smash this to a single line.
There was a problem hiding this comment.
Thanks for the idea. It did reduce the vertical garbage
ProofOfKeags
suggested changes
Jun 20, 2022
ProofOfKeags
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debuging why configSet was slow, was using this trace. @chrisguida thought it would be nice if others could trace this too.