Strict null checks #1464
Merged
Strict null checks #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProofOfKeags
added
Enhancement
|
Few bugs discovered:
|
waterplea
force-pushed
the
strict-null-checks
branch
from
298d86b to
10d5b7e
Compare
elvece
added
P1 - Blocks Release
elvece
reviewed
Jun 8, 2022
elvece
reviewed
Jun 8, 2022
elvece
force-pushed
the
strict-null-checks
branch
from
410563e to
b4a7ccc
Compare
|
Regression tested and reviewed today. Remaining bugs: |
1 task
elvece
force-pushed
the
strict-null-checks
branch
from
619180d to
c657f21
Compare
This was
linked to
issues
Jun 15, 2022
elvece
force-pushed
the
strict-null-checks
branch
4 times, most recently
from
4f04455 to
b407bb2
Compare
feat: enable `noImplicitAny` chore: remove sync data access fix loading package data for affected dependencies chore: properly get alt marketplace data update patchdb client to allow for emit on undefined values
* rework install progress types and pipes for clarity * rework marketplace show display Co-authored-by: Matt Hill <matthill@Matt-M1.local>
* make text selectable on mobile * make logs copyable and adjust copy format * fix linting * fix linting further * linting * add formatting to copied logs * fix copy abstraction and add formatting for server log copy
* display QR code for interfaces * add play-outline to preloader Co-authored-by: Matt Hill <matthill@Matt-M1.local>
swtich certain inputs and displays to courier for readability Co-authored-by: Matt Hill <matthill@Matt-M1.local>
* base styling and action placeholders for package sideload * apparently didnt add new folder * wip * parse manifest and icon from s9pk to upload * wip handle s9pk upload * adjust types, finalize actions, cleanup * clean up and fix data clearing and response * include rest rpc in proxy conf sample * address feedback to use shorthand falsy coercion * update copy and invalid package file ux * do not wait package upload, instead show install progress * fix proxy for rest rpc rename sideload package page titles
config add new list items to end and auto scroll remove js engine artifacts fix view button in notification toast
* refactor app wizards completely * display new and new options in config Co-authored-by: Matt Hill <matthill@Matt-M1.start9.dev>
display success alert if on latest EOS after check for update fix bug with loader dismiss after alert present fix restart button on update complete alert and fix mocks to account for this state fix make clean and adjust default registry names
* no more app wiz or dry calls * change spinner type * better display for update available * reintroduce dep breakages for update/downgrade and style alerts everywhere * only show install alert on first install Co-authored-by: Matt Hill <matthill@Matt-M1.local> Co-authored-by: Matt Hill <matthill@Matt-M1.start9.dev>
elvece
force-pushed
the
strict-null-checks
branch
2 times, most recently
from
b3a7f61 to
eca146a
Compare
* add restart button to service show page and restart rpc api * Feature/restart rpc (#1555) * add restart rpc and status * wire up rpc * add restarting bool Co-authored-by: Aiden McClelland <me@drbonez.dev> * check if service is restarting * filter package when restarting to avoid glitch Co-authored-by: Aiden McClelland <me@drbonez.dev>
elvece
force-pushed
the
strict-null-checks
branch
from
eca146a to
bf2f488
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.