Feat new locking #1384
Merged
Feat new locking #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blu-J
commented
Apr 12, 2022
Blu-J
commented
Apr 12, 2022
Blu-J
commented
Apr 12, 2022
Blu-J
commented
Apr 12, 2022
Blu-J
commented
Apr 14, 2022
Blu-J
commented
Apr 14, 2022
|
Reviewed in person. |
Blu-J
force-pushed
the
feat--new-locking
branch
from
4f4796c to
1f5633f
Compare
* prevent the kernel from OOMKilling embassyd * privilege embassyd with respect to cpu usage * add a docker slice
|
Why is the OOMkill prevention commit in here? Wasn't #1402 merged a while back? |
|
Merging this without the patchdb change being merged seems sus... |
|
I'm not sure how this got merged - I didn't even look at this today... |
|
Ok, so apparently if you force push a branch that has already been merged to a branch that has an open pr, github thinks that it has already been merged. |
|
Something weird happened; I think I pushed a older version of master up, so this pr was a no-op, and got auto merged or had no protections? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test
Test Install/ Uninstall
Videos showing a removal and install of service
install.mp4
uninstalling.mp4
Test - Config
configProof.mp4
Test - Logs
Snap of the system logs
Snap of an app logs
Test - Version
Snap of version
