Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]: resumable downloads for s9pks #1644

Closed
dr-bonez opened this issue Jul 13, 2022 · 0 comments · Fixed by #1733
Closed

[feat]: resumable downloads for s9pks #1644

dr-bonez opened this issue Jul 13, 2022 · 0 comments · Fixed by #1733
Assignees
@redragonx
Labels
Enhancement New feature or request startd Issues pertaining to startd itself
Milestone
0.3.3

Comments

@dr-bonez
Copy link
Member

use Content-Range headers to request rest of s9pk if connection closed before message completed.

Ideally, you can wrap a url in an object that implements AsyncRead and AsyncSeek.
@dr-bonez dr-bonez added Enhancement New feature or request startd Issues pertaining to startd itself labels Jul 13, 2022
@dr-bonez dr-bonez added this to the 0.3.2 milestone Jul 13, 2022
@dr-bonez dr-bonez moved this to Todo in eOS 0.3.3 Jul 13, 2022
@kn0wmad kn0wmad assigned redragonx and unassigned Blu-J Aug 12, 2022
redragonx pushed a commit that referenced this issue Aug 15, 2022
The start of implementing http_reader, issue #1644
f99b7d0
@redragonx redragonx linked a pull request Aug 15, 2022 that will close this issue
Feat: HttpReader #1733
Merged
dr-bonez added a commit that referenced this issue Aug 18, 2022
@redragonx @dr-bonez
Feat: HttpReader (#1733)
6505c40 
* The start of implementing http_reader, issue #1644

* structure done

* v1 of http_reader

* first http_header poc

* Add AsyncSeek trait

* remove import

* move import

* fix typo

* add error checking for async seek

* fix handling of positions

* rename variables

* Update backend/src/util/http_reader.rs

Co-authored-by: Aiden McClelland <3732071+dr-bonez@users.noreply.github.com>

* clean up work

* improve error handling, and change if statement.

Co-authored-by: Stephen Chavez <stephen@start9labs.com>
Co-authored-by: Aiden McClelland <3732071+dr-bonez@users.noreply.github.com>
Repository owner moved this from Todo to Done in eOS 0.3.3 Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redragonx redragonx

Labels
Enhancement New feature or request startd Issues pertaining to startd itself
Projects
No open projects
eOS 0.3.3
Status: Done
Milestone
0.3.3
Development

Successfully merging a pull request may close this issue.

Feat: HttpReader Start9Labs/start-os
3 participants
@Blu-J @redragonx @dr-bonez