Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Display Tor address on LAN setup page when accessed over LAN #1277

Closed
1 task done
chrisguida opened this issue Feb 25, 2022 · 6 comments · Fixed by #1466
Closed
1 task done

[feat]: Display Tor address on LAN setup page when accessed over LAN #1277

chrisguida opened this issue Feb 25, 2022 · 6 comments · Fixed by #1466
Assignees
Labels
Enhancement New feature or request P2 - Desirable high prioity, nice-to-haves UI Issues pertaining to any of the embassy-served web applications

Comments

@chrisguida
Copy link
Contributor

chrisguida commented Feb 25, 2022

Prerequisites

  • I have searched for existing issues that already suggest this feature, without success.

Describe the Feature Request

I have to go find my Tor address whenever I want to download my Root CA. Why? It should just display on this page:

Screen Shot 2022-02-25 at 3 07 29 PM

Describe the Use Case

Eases the already frustrating experience of installing root CAs

Describe Preferred Solution

Tor address should display on the LAN setup page.

Describe Alternatives

Alternatively, could display a link to the Tor address in the About section

Anything else?

No response

@chrisguida chrisguida added the Enhancement New feature or request label Feb 25, 2022
@MattDHill MattDHill added UI Issues pertaining to any of the embassy-served web applications P2 - Desirable high prioity, nice-to-haves labels Mar 10, 2022
@dr-bonez dr-bonez assigned DrewAns and unassigned dr-bonez Mar 13, 2022
@dr-bonez dr-bonez assigned elvece and unassigned DrewAns Mar 13, 2022
@elvece
Copy link
Member

elvece commented Mar 14, 2022

I think it was for security reasons that we initially suggested to only download the cert over Tor, remind me why @dr-bonez ? If there isn't a significant attack vector / value of doing this, then I agree it would be useful to display on this page.

@dr-bonez
Copy link
Member

If they are accessing on lan, it's probably an insecure connection if they've not downloaded the CA yet. But that also means they've sent their master password over an insecure connection anyway so I'm not sure how much it matters.

@chrisguida
Copy link
Contributor Author

Right, and the requested feature is not that we allow downloading of cert over LAN, just that we make it easier to find the Tor address from this page.

@ProofOfKeags
Copy link
Contributor

ProofOfKeags commented Mar 15, 2022

For security reasons you must set up LAN over a Tor connection. Please navigate to your Embassy Tor address and try again.

For security reasons you must set up LAN over a Tor connection. Please navigate to your Embassy Tor address and try again.

We can just have a target="blank_" hyperlink to the embassy tor address in that warning message.

@chrisguida
Copy link
Contributor Author

I'm for it

@elvece
Copy link
Member

elvece commented Mar 16, 2022

Right, and the requested feature is not that we allow downloading of cert over LAN, just that we make it easier to find the Tor address from this page.

Whoops, I def misunderstood the original ask 😅

For sure to all of this.

@elvece elvece assigned MattDHill and unassigned elvece May 4, 2022
elvece pushed a commit that referenced this issue Jun 1, 2022
* style: format lan page component

* Link to tor address on LAN setup page (#1277)
@elvece elvece assigned elvece and unassigned MattDHill Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request P2 - Desirable high prioity, nice-to-haves UI Issues pertaining to any of the embassy-served web applications
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants