Feat/long running (#1676)

* feat: Start the long running container

* feat: Long running docker, running, stoping, and uninstalling

* feat: Just make the folders that we would like to mount.

* fix: Uninstall not working

* chore: remove some logging

* feat: Smarter cleanup

* feat: Wait for start

* wip: Need to kill

* chore: Remove the bad tracing

* feat: Stopping the long running processes without killing the long
running

* Mino Feat: Change the Manifest To have a new type (#1736)

* Add build-essential to README.md (#1716)

Update README.md

* write image to sparse-aware archive format (#1709)

* fix: Add modification to the max_user_watches (#1695)

* fix: Add modification to the max_user_watches

* chore: Move to initialization

* [Feat] follow logs (#1714)

* tail logs

* add cli

* add FE

* abstract http to shared

* batch new logs

* file download for logs

* fix modal error when no config

Co-authored-by: Chris Guida <chrisguida@users.noreply.github.com>
Co-authored-by: Aiden McClelland <me@drbonez.dev>
Co-authored-by: Matt Hill <matthewonthemoon@gmail.com>
Co-authored-by: BluJ <mogulslayer@gmail.com>

* Update README.md (#1728)

* fix build for patch-db client for consistency (#1722)

* fix cli install (#1720)

* highlight instructions if not viewed (#1731)

* wip:

* [ ] Fix the build (dependencies:634 map for option)

* fix: Cargo build

* fix: Long running wasn't starting

* fix: uninstall works

Co-authored-by: Chris Guida <chrisguida@users.noreply.github.com>
Co-authored-by: Aiden McClelland <3732071+dr-bonez@users.noreply.github.com>
Co-authored-by: Aiden McClelland <me@drbonez.dev>
Co-authored-by: Matt Hill <matthewonthemoon@gmail.com>
Co-authored-by: Lucy C <12953208+elvece@users.noreply.github.com>
Co-authored-by: Matt Hill <MattDHill@users.noreply.github.com>

* chore: Fix a dbg!

* chore: Make the commands of the docker-inject do inject instead of exec

* chore: Fix compile mistake

* chore: Change to use simpler

Co-authored-by: Chris Guida <chrisguida@users.noreply.github.com>
Co-authored-by: Aiden McClelland <3732071+dr-bonez@users.noreply.github.com>
Co-authored-by: Aiden McClelland <me@drbonez.dev>
Co-authored-by: Matt Hill <matthewonthemoon@gmail.com>
Co-authored-by: Lucy C <12953208+elvece@users.noreply.github.com>
Co-authored-by: Matt Hill <MattDHill@users.noreply.github.com>

backend/src/action.rs

@@ -8,14 +8,17 @@ use rpc_toolkit::command;
 use serde::{Deserialize, Serialize};
 use tracing::instrument;
 
-use crate::config::{Config, ConfigSpec};
 use crate::context::RpcContext;
 use crate::id::ImageId;
 use crate::procedure::{PackageProcedure, ProcedureName};
 use crate::s9pk::manifest::PackageId;
 use crate::util::serde::{display_serializable, parse_stdin_deserializable, IoFormat};
 use crate::util::Version;
 use crate::volume::Volumes;
+use crate::{
+    config::{Config, ConfigSpec},
+    procedure::docker::DockerContainer,
+};
 use crate::{Error, ResultExt};
 #[derive(Clone, Debug, Default, Deserialize, Serialize)]
 pub struct Actions(pub BTreeMap<ActionId, Action>);
@@ -58,12 +61,13 @@ impl Action {
     #[instrument]
     pub fn validate(
         &self,
+        container: &Option<DockerContainer>,
         eos_version: &Version,
         volumes: &Volumes,
         image_ids: &BTreeSet<ImageId>,
     ) -> Result<(), Error> {
         self.implementation
-            .validate(eos_version, volumes, image_ids, true)
+            .validate(container, eos_version, volumes, image_ids, true)
             .with_ctx(|_| {
                 (
                     crate::ErrorKind::ValidateS9pk,
@@ -76,6 +80,7 @@ impl Action {
     pub async fn execute(
         &self,
         ctx: &RpcContext,
+        container: &Option<DockerContainer>,
         pkg_id: &PackageId,
         pkg_version: &Version,
         action_id: &ActionId,
@@ -90,12 +95,12 @@ impl Action {
         self.implementation
             .execute(
                 ctx,
+                container,
                 pkg_id,
                 pkg_version,
                 ProcedureName::Action(action_id.clone()),
                 volumes,
                 input,
-                true,
                 None,
             )
             .await?
@@ -141,10 +146,24 @@ pub async fn action(
         .get(&mut db, true)
         .await?
         .to_owned();
+
+    let container = crate::db::DatabaseModel::new()
+        .package_data()
+        .idx_model(&pkg_id)
+        .and_then(|p| p.installed())
+        .expect(&mut db)
+        .await
+        .with_kind(crate::ErrorKind::NotFound)?
+        .manifest()
+        .container()
+        .get(&mut db, false)
+        .await?
+        .to_owned();
     if let Some(action) = manifest.actions.0.get(&action_id) {
         action
             .execute(
                 &ctx,
+                &container,
                 &manifest.id,
                 &manifest.version,
                 &action_id,

backend/src/backup/mod.rs

@@ -14,7 +14,6 @@ use tokio::io::AsyncWriteExt;
 use tracing::instrument;
 
 use self::target::PackageBackupInfo;
-use crate::context::RpcContext;
 use crate::dependencies::reconfigure_dependents_with_live_pointers;
 use crate::id::ImageId;
 use crate::install::PKG_ARCHIVE_DIR;
@@ -25,6 +24,7 @@ use crate::util::serde::IoFormat;
 use crate::util::Version;
 use crate::version::{Current, VersionT};
 use crate::volume::{backup_dir, Volume, VolumeId, Volumes, BACKUP_DIR};
+use crate::{context::RpcContext, procedure::docker::DockerContainer};
 use crate::{Error, ErrorKind, ResultExt};
 
 pub mod backup_bulk;
@@ -73,15 +73,16 @@ pub struct BackupActions {
 impl BackupActions {
     pub fn validate(
         &self,
+        container: &Option<DockerContainer>,
         eos_version: &Version,
         volumes: &Volumes,
         image_ids: &BTreeSet<ImageId>,
     ) -> Result<(), Error> {
         self.create
-            .validate(eos_version, volumes, image_ids, false)
+            .validate(container, eos_version, volumes, image_ids, false)
             .with_ctx(|_| (crate::ErrorKind::ValidateS9pk, "Backup Create"))?;
         self.restore
-            .validate(eos_version, volumes, image_ids, false)
+            .validate(container, eos_version, volumes, image_ids, false)
             .with_ctx(|_| (crate::ErrorKind::ValidateS9pk, "Backup Restore"))?;
         Ok(())
     }
@@ -100,18 +101,30 @@ impl BackupActions {
         let mut volumes = volumes.to_readonly();
         volumes.insert(VolumeId::Backup, Volume::Backup { readonly: false });
         let backup_dir = backup_dir(pkg_id);
+        let container = crate::db::DatabaseModel::new()
+            .package_data()
+            .idx_model(&pkg_id)
+            .and_then(|p| p.installed())
+            .expect(db)
+            .await
+            .with_kind(crate::ErrorKind::NotFound)?
+            .manifest()
+            .container()
+            .get(db, false)
+            .await?
+            .to_owned();
         if tokio::fs::metadata(&backup_dir).await.is_err() {
             tokio::fs::create_dir_all(&backup_dir).await?
         }
         self.create
             .execute::<(), NoOutput>(
                 ctx,
+                &container,
                 pkg_id,
                 pkg_version,
                 ProcedureName::CreateBackup,
                 &volumes,
                 None,
-                false,
                 None,
             )
             .await?
@@ -186,6 +199,7 @@ impl BackupActions {
     #[instrument(skip(ctx, db, secrets))]
     pub async fn restore<Ex, Db: DbHandle>(
         &self,
+        container: &Option<DockerContainer>,
         ctx: &RpcContext,
         db: &mut Db,
         secrets: &mut Ex,
@@ -202,12 +216,12 @@ impl BackupActions {
         self.restore
             .execute::<(), NoOutput>(
                 ctx,
+                container,
                 pkg_id,
                 pkg_version,
                 ProcedureName::RestoreBackup,
                 &volumes,
                 None,
-                false,
                 None,
             )
             .await?

backend/src/config/action.rs

@@ -7,14 +7,14 @@ use serde::{Deserialize, Serialize};
 use tracing::instrument;
 
 use super::{Config, ConfigSpec};
-use crate::context::RpcContext;
 use crate::dependencies::Dependencies;
 use crate::id::ImageId;
 use crate::procedure::{PackageProcedure, ProcedureName};
 use crate::s9pk::manifest::PackageId;
 use crate::status::health_check::HealthCheckId;
 use crate::util::Version;
 use crate::volume::Volumes;
+use crate::{context::RpcContext, procedure::docker::DockerContainer};
 use crate::{Error, ResultExt};
 
 #[derive(Debug, Deserialize, Serialize, HasModel)]
@@ -33,35 +33,37 @@ impl ConfigActions {
     #[instrument]
     pub fn validate(
         &self,
+        container: &Option<DockerContainer>,
         eos_version: &Version,
         volumes: &Volumes,
         image_ids: &BTreeSet<ImageId>,
     ) -> Result<(), Error> {
         self.get
-            .validate(eos_version, volumes, image_ids, true)
+            .validate(container, eos_version, volumes, image_ids, true)
             .with_ctx(|_| (crate::ErrorKind::ValidateS9pk, "Config Get"))?;
         self.set
-            .validate(eos_version, volumes, image_ids, true)
+            .validate(container, eos_version, volumes, image_ids, true)
             .with_ctx(|_| (crate::ErrorKind::ValidateS9pk, "Config Set"))?;
         Ok(())
     }
     #[instrument(skip(ctx))]
     pub async fn get(
         &self,
         ctx: &RpcContext,
+        container: &Option<DockerContainer>,
         pkg_id: &PackageId,
         pkg_version: &Version,
         volumes: &Volumes,
     ) -> Result<ConfigRes, Error> {
         self.get
             .execute(
                 ctx,
+                container,
                 pkg_id,
                 pkg_version,
                 ProcedureName::GetConfig,
                 volumes,
                 None::<()>,
-                false,
                 None,
             )
             .await
@@ -74,6 +76,7 @@ impl ConfigActions {
     pub async fn set(
         &self,
         ctx: &RpcContext,
+        container: &Option<DockerContainer>,
         pkg_id: &PackageId,
         pkg_version: &Version,
         dependencies: &Dependencies,
@@ -84,12 +87,12 @@ impl ConfigActions {
             .set
             .execute(
                 ctx,
+                container,
                 pkg_id,
                 pkg_version,
                 ProcedureName::SetConfig,
                 volumes,
                 Some(input),
-                false,
                 None,
             )
             .await

backend/src/config/mod.rs

@@ -13,7 +13,6 @@ use rpc_toolkit::command;
 use serde_json::Value;
 use tracing::instrument;
 
-use crate::context::RpcContext;
 use crate::db::model::{CurrentDependencies, CurrentDependencyInfo, CurrentDependents};
 use crate::dependencies::{
     add_dependent_to_current_dependents_lists, break_transitive, heal_all_dependents_transitive,
@@ -25,6 +24,7 @@ use crate::s9pk::manifest::{Manifest, PackageId};
 use crate::util::display_none;
 use crate::util::serde::{display_serializable, parse_stdin_deserializable, IoFormat};
 use crate::Error;
+use crate::{context::RpcContext, procedure::docker::DockerContainer};
 
 pub mod action;
 pub mod spec;
@@ -167,6 +167,7 @@ pub struct ConfigGetReceipts {
     manifest_volumes: LockReceipt<crate::volume::Volumes, ()>,
     manifest_version: LockReceipt<crate::util::Version, ()>,
     manifest_config: LockReceipt<Option<ConfigActions>, ()>,
+    docker_container: LockReceipt<DockerContainer, String>,
 }
 
 impl ConfigGetReceipts {
@@ -202,11 +203,19 @@ impl ConfigGetReceipts {
             .map(|x| x.manifest().config())
             .make_locker(LockType::Write)
             .add_to_keys(locks);
+        let docker_container = crate::db::DatabaseModel::new()
+            .package_data()
+            .star()
+            .installed()
+            .and_then(|x| x.manifest().container())
+            .make_locker(LockType::Write)
+            .add_to_keys(locks);
         move |skeleton_key| {
             Ok(Self {
                 manifest_volumes: manifest_volumes.verify(skeleton_key)?,
                 manifest_version: manifest_version.verify(skeleton_key)?,
                 manifest_config: manifest_config.verify(skeleton_key)?,
+                docker_container: docker_container.verify(skeleton_key)?,
             })
         }
     }
@@ -229,9 +238,11 @@ pub async fn get(
         .await?
         .ok_or_else(|| Error::new(eyre!("{} has no config", id), crate::ErrorKind::NotFound))?;
 
+    let container = receipts.docker_container.get(&mut db, &id).await?;
+
     let volumes = receipts.manifest_volumes.get(&mut db).await?;
     let version = receipts.manifest_version.get(&mut db).await?;
-    action.get(&ctx, &id, &version, &volumes).await
+    action.get(&ctx, &container, &id, &version, &volumes).await
 }
 
 #[command(
@@ -274,6 +285,7 @@ pub struct ConfigReceipts {
     pub current_dependencies: LockReceipt<CurrentDependencies, String>,
     dependency_errors: LockReceipt<DependencyErrors, String>,
     manifest_dependencies_config: LockReceipt<DependencyConfig, (String, String)>,
+    docker_container: LockReceipt<DockerContainer, String>,
 }
 
 impl ConfigReceipts {
@@ -378,6 +390,13 @@ impl ConfigReceipts {
             .and_then(|x| x.manifest().dependencies().star().config())
             .make_locker(LockType::Write)
             .add_to_keys(locks);
+        let docker_container = crate::db::DatabaseModel::new()
+            .package_data()
+            .star()
+            .installed()
+            .and_then(|x| x.manifest().container())
+            .make_locker(LockType::Write)
+            .add_to_keys(locks);
 
         move |skeleton_key| {
             Ok(Self {
@@ -397,6 +416,7 @@ impl ConfigReceipts {
                 current_dependencies: current_dependencies.verify(skeleton_key)?,
                 dependency_errors: dependency_errors.verify(skeleton_key)?,
                 manifest_dependencies_config: manifest_dependencies_config.verify(skeleton_key)?,
+                docker_container: docker_container.verify(skeleton_key)?,
             })
         }
     }
@@ -488,6 +508,8 @@ pub fn configure_rec<'a, Db: DbHandle>(
     receipts: &'a ConfigReceipts,
 ) -> BoxFuture<'a, Result<(), Error>> {
     async move {
+        let container = receipts.docker_container.get(db, &id).await?;
+        let container = &container;
         // fetch data from db
         let action = receipts
             .config_actions
@@ -511,7 +533,7 @@ pub fn configure_rec<'a, Db: DbHandle>(
         let ConfigRes {
             config: old_config,
             spec,
-        } = action.get(ctx, id, &version, &volumes).await?;
+        } = action.get(ctx, container, id, &version, &volumes).await?;
 
         // determine new config to use
         let mut config = if let Some(config) = config.or_else(|| old_config.clone()) {
@@ -579,7 +601,15 @@ pub fn configure_rec<'a, Db: DbHandle>(
         let signal = if !dry_run {
             // run config action
             let res = action
-                .set(ctx, id, &version, &dependencies, &volumes, &config)
+                .set(
+                    ctx,
+                    container,
+                    id,
+                    &version,
+                    &dependencies,
+                    &volumes,
+                    &config,
+                )
                 .await?;
 
             // track dependencies with no pointers
@@ -671,6 +701,8 @@ pub fn configure_rec<'a, Db: DbHandle>(
             .unwrap_or_default();
         let next = Value::Object(config.clone());
         for (dependent, dep_info) in dependents.0.iter().filter(|(dep_id, _)| dep_id != &id) {
+            let dependent_container = receipts.docker_container.get(db, &dependent).await?;
+            let dependent_container = &dependent_container;
             // check if config passes dependent check
             if let Some(cfg) = receipts
                 .manifest_dependencies_config
@@ -685,6 +717,7 @@ pub fn configure_rec<'a, Db: DbHandle>(
                 if let Err(error) = cfg
                     .check(
                         ctx,
+                        dependent_container,
                         dependent,
                         &manifest.version,
                         &manifest.volumes,