Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow positional arguments after optional arguments #5

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Disallow positional arguments after optional arguments #5

merged 1 commit into from
Dec 7, 2021

Conversation

juniperparsnips
Copy link

See #4 for rationale.

@juniperparsnips juniperparsnips changed the title Disallow optional arguments after positional arguments Disallow positional arguments after optional arguments Dec 7, 2021
@juniperparsnips juniperparsnips force-pushed the parsons20/optional-parameters-must-be-last branch from 0bbc3ad to feaff25 Compare December 7, 2021 15:10
@agreen17
Copy link

agreen17 commented Dec 7, 2021

Changes look good to me.

I see that tests are passing but clippy is failing in CI. Since there seems to be some uncertainty upstream with regards to fixing these lints, I think it's fine to merge this as-is with the clippy failures and all.

@juniperparsnips juniperparsnips merged commit b01b8df into starry/0.15.1 Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Property404 Property404 Awaiting requested review from Property404

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juniperparsnips @agreen17