Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.4.1 #706

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Ruby 3.4.1 #706

merged 4 commits into from
Jan 3, 2025

Conversation

dentarg
Copy link
Member

@dentarg dentarg commented Dec 25, 2024

This fails locally for me on (first that my rustc was too old, then some more exotic thing)

Installing selma 0.2.2 with native extensions

Not sure why it doesn't install

selma-0.2.2-arm64-darwin

that I have installed for Ruby 3.3.5

@dentarg
Copy link
Member Author

dentarg commented Dec 25, 2024

Not sure why it doesn't install

maybe because platform gems are (can be) specific to a certain Ruby version?

@dentarg
Copy link
Member Author

dentarg commented Dec 25, 2024

For the record, I could build the latest selma release

$ gem install selma
Fetching selma-0.4.10.gem
Building native extensions. This could take a while...
Successfully installed selma-0.4.10
1 gem installed

@dentarg
Copy link
Member Author

dentarg commented Dec 25, 2024

I created gjtorikian/selma#90

There are no binary releases of selma for Ruby 3.4 yet.

0.2.2 didn't build for me, but 0.4.10 does.
@dentarg dentarg marked this pull request as ready for review December 26, 2024 15:17
@dentarg dentarg added the preview Deploy to preview app label Jan 3, 2025
@dentarg
Copy link
Member Author

dentarg commented Jan 3, 2025

Tested https://wikimum-preview.fly.dev/

@dentarg dentarg removed the preview Deploy to preview app label Jan 3, 2025
@dentarg dentarg merged commit 35de030 into main Jan 3, 2025
11 checks passed
@dentarg dentarg deleted the ruby-3.4 branch January 3, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants