-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve incorrect JsonPatchError format for Arrays #221
Conversation
JsonPatchErrors in applyOperation now reference index Arrays now reference index, operation, and document when throwing a JsonPatchError
Thank you @ianvonholt for your submission. We want to accept this. The PR is lacking a test, though. Would you please like to contribute that? |
I'm taking over this. |
Test the behaviour introduced in PR Starcounter-Jack#221
This is ready for review. |
Thank you @alshakero. I had completely forgotten about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks good, but I am missing a test for new error message formatting feature. @alshakero could you please add it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
JsonPatchError
See: #220