Changing 0 to empty string should create a patch

Starcounter-Jack · Nov 17, 2016 · a471f21 · a471f21
1 parent 20ed496
commit a471f21
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/src/json-patch-duplex.js b/src/json-patch-duplex.js
@@ -353,7 +353,7 @@ var jsonpatch;
                     _generate(oldVal, newVal, patches, path + "/" + escapePathComponent(key));
                 }
                 else {
-                    if (oldVal != newVal) {
+                    if (oldVal !== newVal) {
                         changed = true;
                         patches.push({ op: "replace", path: path + "/" + escapePathComponent(key), value: deepClone(newVal) });
                     }

diff --git a/src/json-patch-duplex.ts b/src/json-patch-duplex.ts
@@ -401,7 +401,7 @@ module jsonpatch {
           _generate(oldVal, newVal, patches, path + "/" + escapePathComponent(key));
         }
         else {
-          if (oldVal != newVal) {
+          if (oldVal !== newVal) {
             changed = true;
             patches.push({op: "replace", path: path + "/" + escapePathComponent(key), value: deepClone(newVal)});
           }

diff --git a/test/spec/duplexSpec.js b/test/spec/duplexSpec.js
@@ -1311,6 +1311,21 @@ describe("duplex", function() {
                 value: null
             }]);
         });
+
+        it("should replace 0 with empty string", function () {
+            var objA = {
+                user: 0
+            };
+            var objB = {
+                user: ''
+            };
+
+            expect(jsonpatch.compare(objA, objB)).toReallyEqual([{
+                op: "replace",
+                path: "/user",
+                value: ''
+            }]);
+        });
     });