Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use docker implementation #1

Merged
merged 3 commits into from
Mar 29, 2022
Merged

feat: use docker implementation #1

merged 3 commits into from
Mar 29, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 29, 2022

No description provided.

@ghost ghost requested a review from Teakowa March 29, 2022 02:44
@ghost ghost self-assigned this Mar 29, 2022
action.yml Outdated
@@ -0,0 +1,12 @@
name: 'starubiquitous kubectl-argo-rollouts cli'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: 'starubiquitous kubectl-argo-rollouts cli'
name: 'kubectl-argo-rollouts cli'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update

@Teakowa
Copy link
Member

Teakowa commented Mar 29, 2022

没有 release workflow 的话,commit changes 需要手动 release

@ghost
Copy link
Author

ghost commented Mar 29, 2022

我在workflows 的分支实现 release

@Teakowa
Copy link
Member

Teakowa commented Mar 29, 2022

基础的 Workflow 应该提前合并

@ghost
Copy link
Author

ghost commented Mar 29, 2022

好的,我开个PR 来实现。

@Teakowa Teakowa merged commit bbaaeb7 into main Mar 29, 2022
@Teakowa Teakowa deleted the feat/docker branch March 29, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant