Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] use git-commit-id-plugin to get git information at runtime #213

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

banmoy
Copy link
Collaborator

@banmoy banmoy commented Apr 17, 2023

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes #

Problem Summary(Required) :

Use git-commit-id-plugin to get git information at runtime. This will help users to determine which version of code they are running, especially when the jar is packaged by the users themselves. With this feature, mvn clean package will generate a resource file starrocks-connector-git.properties like this
image

And git information will be printed to the taskmanager log as follows
image
image

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function

banmoy added 2 commits April 17, 2023 20:41
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
@banmoy banmoy merged commit ef21559 into StarRocks:main Apr 18, 2023
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Apr 23, 2023
…tarRocks#213)

[Feature] use git-commit-id-plugin to get git information at runtime

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Apr 23, 2023
…tarRocks#213)

[Feature] use git-commit-id-plugin to get git information at runtime

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Apr 23, 2023
…tarRocks#213)

[Feature] use git-commit-id-plugin to get git information at runtime

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request May 5, 2023
…tarRocks#213)

[Feature] use git-commit-id-plugin to get git information at runtime

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request May 5, 2023
…tarRocks#213)

[Feature] use git-commit-id-plugin to get git information at runtime

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit that referenced this pull request May 5, 2023
…213)

[Feature] use git-commit-id-plugin to get git information at runtime

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit that referenced this pull request May 5, 2023
…213)

[Feature] use git-commit-id-plugin to get git information at runtime

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit that referenced this pull request May 5, 2023
…213)

[Feature] use git-commit-id-plugin to get git information at runtime

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit that referenced this pull request May 5, 2023
…213)

[Feature] use git-commit-id-plugin to get git information at runtime

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit that referenced this pull request May 5, 2023
…213)

[Feature] use git-commit-id-plugin to get git information at runtime

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants