[Enhancement] Exit getLabelState() if retry for more than a certain time #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
xlfjcg
reviewed
Apr 12, 2023
| @@ -105,17 +105,29 @@ public Map<String, Object> doStreamLoad(StarRocksSinkBufferEntity bufferEntity) | |||
| } else if (RESULT_LABEL_EXISTED.equals(loadResult.get(keyStatus))) { | |||
| LOG.error(String.format("Stream Load response: \n%s\n", JSON.toJSONString(loadResult))); | |||
| // has to block-checking the state to get the final result | |||
| checkLabelState(host, bufferEntity.getLabel()); | |||
| int timeoutSecond = 600; | |||
| String configuredTimeout = sinkOptions.getSinkStreamLoadProperties().get("timeout"); | |||
There was a problem hiding this comment.
It might be better to get it early, and Isn't it ten minutes by default if you don't set it?
There was a problem hiding this comment.
What do you mean by "get it early"? 600s is just ten minutes
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
xlfjcg
approved these changes
Apr 12, 2023
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Apr 23, 2023
…ime (StarRocks#212) Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Apr 23, 2023
…ime (StarRocks#212) Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Apr 23, 2023
…ime (StarRocks#212) Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
May 5, 2023
…ime (StarRocks#212) Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
May 5, 2023
…ime (StarRocks#212) Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
that referenced
this pull request
May 5, 2023
…ime (#212) Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
that referenced
this pull request
May 5, 2023
…ime (#212) Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
that referenced
this pull request
May 5, 2023
…ime (#212) Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
that referenced
this pull request
May 5, 2023
…ime (#212) Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
that referenced
this pull request
May 5, 2023
…ime (#212) Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #
Problem Summary(Required) ：
currently
StarRocksStreamLoadVisitor#checkLabelStateandDefaultStreamLoader#getLabelStatewill continue retrying if not get the expected label state. This may be caused by the bug of StarRocks, such as StarRocks/starrocks#21127. In this case, connector is better to throw some exception to tell the flink user what happens rather than stuck here, and then can investigate the problem.Checklist: