[Enhancement] Support https load url #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoyli
reviewed
Dec 5, 2022
| @@ -35,8 +35,13 @@ public class ConnectionUtils { | |||
| @Nullable | |||
| public static String selectAvailableHttpHost(List<String> hostList, int connectionTimeout) { | |||
| for (String host : hostList) { | |||
| String urlStr = "http://" + host; | |||
| if (testHttpConnection(urlStr, connectionTimeout)) { | |||
| if (host == null) { | |||
banmoy
reviewed
Dec 6, 2022
| @@ -183,7 +183,10 @@ private String getAvailableHost() { | |||
| List<String> hostList = sinkOptions.getLoadUrlList(); | |||
| long tmp = pos + hostList.size(); | |||
| while (pos < tmp) { | |||
| String host = "http://" + hostList.get((int) (pos % hostList.size())); | |||
| String host = hostList.get((int) (pos % hostList.size())); | |||
| if (host != null && !host.startsWith("http")) { | |||
There was a problem hiding this comment.
How about moving this logic to StarRocksSinkOptions#getLoadUrlList to reduce code duplication? getLoadUrlList can return urls already prefixed with http or https.
|
We should update the description of |
banmoy
changed the title
Signed-off-by: xlfjcg <1937532871@qq.com>
banmoy
approved these changes
Dec 12, 2022
banmoy
pushed a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Dec 14, 2022
Signed-off-by: xlfjcg <1937532871@qq.com>
banmoy
pushed a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Dec 14, 2022
Signed-off-by: xlfjcg <1937532871@qq.com>
banmoy
pushed a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Dec 14, 2022
Signed-off-by: xlfjcg <1937532871@qq.com>
banmoy
pushed a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Dec 14, 2022
Signed-off-by: xlfjcg <1937532871@qq.com>
banmoy
pushed a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Dec 14, 2022
Signed-off-by: xlfjcg <1937532871@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.