Skip to content
This repository has been archived by the owner on Jun 27, 2024. It is now read-only.

[BUG WARN] - Video duration is incorrect when fetched with popyt #7

Closed
brandonbothell opened this issue Feb 26, 2021 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@brandonbothell
Copy link

Descripción del problema

Hello, creator of popyt here. There is an error with how the duration is set with popyt on videos here: https://github.com/StarArmyDev/starmusic/blob/main/src/Music.ts#L604
The issue is that popyt separates the length of the video into two properties, video.minutes and video.seconds. The minutes property is how many minutes are in the video, and the seconds property is how many seconds are after that. For example, this would be formatted as ${video.minutes}:${video.seconds}. The program treats it as if the video.seconds property contains the total number of seconds in the video.

Thanks for using popyt!

@DavichoStar
Copy link
Member

Hello @jasonhaxstuff, thanks for noticing. I had already noticed and corrected it in time on the line: https://github.com/StarArmyDev/starmusic/blob/main/src/index.ts#L96 but I forgot that I also occupied it on that line that you mentioned.

Nice to use popyt, good job.

@DavichoStar DavichoStar added the bug Something isn't working label Feb 26, 2021
@DavichoStar DavichoStar self-assigned this Feb 26, 2021
@DavichoStar DavichoStar changed the title [BUG ERROR WARN] - Video duration is incorrect when fetched with popyt [BUG WARN] - Video duration is incorrect when fetched with popyt Feb 26, 2021
DavichoStar added a commit that referenced this issue Mar 4, 2021
- Corrección en el tiempo cuando se agrega una canción a la cola. #7

- Corrección en las imagenes y ejemplos del readme.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants