Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/robot self collision #939

Merged
merged 3 commits into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions omnigibson/examples/robots/robot_control_example.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,19 @@ def choose_controllers(robot, random_selection=False):
default_config = robot._default_controller_config

# Iterate over all components in robot
for component, controller_options in default_config.items():
controller_names = robot.controller_order
for controller_name in controller_names:
controller_options = default_config[controller_name]
# Select controller
options = list(sorted(controller_options.keys()))
choice = choose_from_options(
options=options, name="{} controller".format(component), random_selection=random_selection
options=options,
name=f"{controller_name} controller",
random_selection=random_selection,
)

# Add to user responses
controller_choices[component] = choice
controller_choices[controller_name] = choice

return controller_choices

Expand Down
6 changes: 3 additions & 3 deletions omnigibson/robots/a1.py
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ def assisted_grasp_end_points(self):
@property
def disabled_collision_pairs(self):
# some dexhand has self collisions that needs to be filtered out
pairs = [["base_link", "connector"]]
if self.end_effector == "inspire":
return [["base_link", "link12"]]
else:
return []
pairs.append(["base_link", "link12"])
return pairs
2 changes: 1 addition & 1 deletion omnigibson/robots/articulated_trunk_robot.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def __init__(
scale=None,
visible=True,
visual_only=False,
self_collisions=False,
self_collisions=True,
load_config=None,
fixed_base=False,
# Unique to USDObject hierarchy
Expand Down
2 changes: 1 addition & 1 deletion omnigibson/robots/fetch.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def __init__(
scale=None,
visible=True,
visual_only=False,
self_collisions=False,
self_collisions=True,
load_config=None,
fixed_base=False,
# Unique to USDObject hierarchy
Expand Down
2 changes: 1 addition & 1 deletion omnigibson/robots/holonomic_base_robot.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def __init__(
visible=True,
fixed_base=False,
visual_only=False,
self_collisions=False,
self_collisions=True,
load_config=None,
# Unique to USDObject hierarchy
abilities=None,
Expand Down
12 changes: 12 additions & 0 deletions omnigibson/robots/locobot.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,15 @@ def usd_path(self):
@property
def urdf_path(self):
return os.path.join(gm.ASSET_PATH, "models/locobot/locobot.urdf")

@property
def disabled_collision_pairs(self):
# badly modeled gripper collision meshes
return [
["base_link", "arm_base_link"],
["base_link", "plate_2"],
["cam_mount", "forearm_link"],
["cam_mount", "elbow_link"],
["cam_mount", "plate_1"],
["cam_mount", "plate_2"],
]
2 changes: 1 addition & 1 deletion omnigibson/robots/manipulation_robot.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def __init__(
visible=True,
fixed_base=False,
visual_only=False,
self_collisions=False,
self_collisions=True,
load_config=None,
# Unique to USDObject hierarchy
abilities=None,
Expand Down
2 changes: 1 addition & 1 deletion omnigibson/robots/mobile_manipulation_robot.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def __init__(
scale=None,
visible=True,
visual_only=False,
self_collisions=False,
self_collisions=True,
load_config=None,
fixed_base=False,
# Unique to USDObject hierarchy
Expand Down
5 changes: 4 additions & 1 deletion omnigibson/robots/r1.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def __init__(
scale=None,
visible=True,
visual_only=False,
self_collisions=False,
self_collisions=True,
load_config=None,
# Unique to USDObject hierarchy
abilities=None,
Expand Down Expand Up @@ -254,4 +254,7 @@ def disabled_collision_pairs(self):
return [
["left_gripper_link1", "left_gripper_link2"],
["right_gripper_link1", "right_gripper_link2"],
["base_link", "wheel_link1"],
["base_link", "wheel_link2"],
["base_link", "wheel_link3"],
]
2 changes: 1 addition & 1 deletion omnigibson/robots/robot_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def __init__(
visible=True,
fixed_base=False,
visual_only=False,
self_collisions=False,
self_collisions=True,
load_config=None,
# Unique to USDObject hierarchy
abilities=None,
Expand Down
7 changes: 7 additions & 0 deletions omnigibson/robots/stretch.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,14 @@ def disabled_collision_pairs(self):
["link_arm_l4", "link_arm_l3"],
["link_arm_l4", "link_arm_l2"],
["link_arm_l4", "link_arm_l1"],
["link_arm_l4", "link_aruco_inner_wrist"],
["link_arm_l3", "link_arm_l2"],
["link_arm_l3", "link_arm_l1"],
["link_arm_l3", "link_aruco_top_wrist"],
["link_arm_l3", "link_aruco_inner_wrist"],
["link_arm_l2", "link_arm_l1"],
["link_arm_l2", "link_aruco_top_wrist"],
["link_arm_l2", "link_aruco_inner_wrist"],
["link_arm_l0", "link_arm_l1"],
["link_arm_l0", "link_arm_l2"],
["link_arm_l0", "link_arm_l3"],
Expand All @@ -131,6 +136,8 @@ def disabled_collision_pairs(self):
["link_arm_l0", "link_wrist_yaw_bottom"],
["link_arm_l0", "link_wrist_pitch"],
["link_wrist_yaw_bottom", "link_wrist_pitch"],
["link_wrist_yaw_bottom", "link_arm_l4"],
["link_wrist_yaw_bottom", "link_arm_l3"],
["gripper_camera_link", "link_gripper_s3_body"],
["link_gripper_s3_body", "link_aruco_d405"],
["link_gripper_s3_body", "link_gripper_finger_left"],
Expand Down
2 changes: 1 addition & 1 deletion omnigibson/robots/tiago.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def __init__(
scale=None,
visible=True,
visual_only=False,
self_collisions=False,
self_collisions=True,
load_config=None,
# Unique to USDObject hierarchy
abilities=None,
Expand Down
26 changes: 26 additions & 0 deletions omnigibson/robots/turtlebot.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,29 @@ def usd_path(self):
@property
def urdf_path(self):
return os.path.join(gm.ASSET_PATH, "models/turtlebot/turtlebot.urdf")

@property
def disabled_collision_pairs(self):
# badly modeled gripper collision meshes
return [
["plate_bottom_link", "pole_middle_0_link"],
["plate_bottom_link", "pole_middle_2_link"],
["plate_middle_link", "pole_top_3_link"],
["plate_middle_link", "pole_kinect_0_link"],
["plate_middle_link", "pole_kinect_1_link"],
["plate_middle_link", "pole_top_1_link"],
["plate_middle_link", "pole_middle_0_link"],
["plate_middle_link", "pole_middle_1_link"],
["plate_middle_link", "pole_middle_2_link"],
["plate_middle_link", "pole_middle_3_link"],
["plate_top_link", "pole_top_0_link"],
["plate_top_link", "pole_top_1_link"],
["plate_top_link", "pole_top_2_link"],
["plate_top_link", "pole_top_3_link"],
["pole_top_0_link", "pole_middle_0_link"],
["pole_top_0_link", "plate_middle_link"],
["pole_top_1_link", "pole_middle_1_link"],
["pole_top_2_link", "pole_middle_2_link"],
["pole_top_2_link", "plate_middle_link"],
["pole_top_3_link", "pole_middle_3_link"],
]
2 changes: 1 addition & 1 deletion omnigibson/robots/untucked_arm_pose_robot.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def __init__(
scale=None,
visible=True,
visual_only=False,
self_collisions=False,
self_collisions=True,
load_config=None,
fixed_base=False,
# Unique to USDObject hierarchy
Expand Down
Loading