Lie to the Swift compiler about isolation #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lie to the Swift compiler about isolation
♻️ Current situation & Problem
In PR #14 we truthfully implemented strict concurrency checking for the XCTRuntimeAssertions library. However, this made it impossible to test runtime precondition failures on the
@MainActor
as it would completely block the actor (or the Task would only be scheduled after theXCTRuntimePrecondition
call returned).Therefore, it is necessary to always run
XCTRuntimePrecondition
expressions on a background thread. If we would keep correct@Sendable
annotations for the expression closure, this would make it impossible to runXCTRuntimePrecondition
s on the@MainActor
. Therefore, we lie to the compiler. We deliberately don't annotate the expression closure as@Sendable
and silence the respective concurrency warning.The impact of that is documented.
⚙️ Release Notes
@MainActor
.📚 Documentation
Add documentation bubbles to explain the impact.
✅ Testing
Add unit testing to prevent regressions.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: