Adds Nextjs Loader #909
Merged
Adds Nextjs Loader #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ghost
lucasrmp-cb
requested changes
May 24, 2024
src/app/[locale]/layout.tsx
Outdated
Comment on lines
76
to
77
| color="#6200FF" | ||
| shadow="0 0 10px #6200FF,0 0 5px #6200FF" |
There was a problem hiding this comment.
To avoid hard coding colors we could use a css variable injected by tailwind here
Suggested change
| color="#6200FF" | |
| shadow="0 0 10px #6200FF,0 0 5px #6200FF" | |
| color="hsl(var(--primary-cta))" | |
| shadow="0 0 10px hsl(var(--primary-cta)),0 0 5px hsl(var(--primary-cta))" |
ghost
approved these changes
May 24, 2024
lucasrmp-cb
approved these changes
May 24, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #91
What changed? Why?
This PR adds the NextJS Loader lib to SWC after this issue has been resolved.
How has it been tested?