Skip to content

Commit

Permalink
fix(tests): remove @node/types (#386)
Browse files Browse the repository at this point in the history
stampy.ts tests were failing (e.g. https://github.com/StampyAI/stampy-ui/actions/runs/7854687158/job/21435971107) with the following error:

```
    app/server-utils/stampy.ts:196:45 - error TS2576: Property 'json' does not exist on type 'Response'. Did you mean to access the static member 'Response.json' instead?

    196     json = await (await fetch(url, params)).json()
```

Removed @nodes/types as I think it was due to the types conflict described cloudflare/workerd#1298.
  • Loading branch information
jrhender committed Feb 10, 2024
1 parent 73c6d7b commit 73e2b92
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 34 deletions.
59 changes: 26 additions & 33 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
"@types/lodash": "^4.14.202",
"@types/markdown-it": "^13.0.7",
"@types/markdown-it-footnote": "^3.0.3",
"@types/node": "^20.11.16",
"@types/react": "^18.2.53",
"@types/react-dom": "^18.2.18",
"@typescript-eslint/eslint-plugin": "^6.20.0",
Expand Down

0 comments on commit 73e2b92

Please sign in to comment.