Update Node version to current #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
arm4b
approved these changes
Oct 21, 2023
cognifloyd
approved these changes
Oct 22, 2023
|
Uh oh, looks like unit tests still 🔴 failed on master after merging: weird it worked before in this PR |
|
Nevermind, st2web nightly build succeeded: https://app.circleci.com/pipelines/github/StackStorm/st2web/3956/workflows/3247ed21-1e34-46c3-adce-9a4d3e05cf11 so we're good 👍 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Node version being used during build and test runs. The web app itself does not have any dependencies on libraries provided by Node, but it's still good to keep this dependency reasonably up to date.
Node v20 is about to become LTS in the next few days. Seems like a good timing to ensure we're compatible with the current version.