-
-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problems connecting to redis sentinel with SSL #5660
Conversation
Amanda, Please let us know which version of Redis you used to fix the Redis and Sentinel issues for TLS. Redis officially supports TLS from their 6.0 version onwards. Text from redis.io : "SSL/TLS is supported by Redis starting with version 6 as an optional feature that needs to be enabled at compile time." Are you using the latest Redis version 7.0 or 6.2.2? |
I used 6.2.7 and compiled at run-time to enable SSL for my testing (which is latest on the 6.2 stream). But the changes here are compatible with non-SSL and SSL redis versions, so work fine with the versions that the bash installer uses (though in those cases the package manager will pull down non-SSL version of redis), therefore if using the package manager redis you won't have SSL support. |
Amanda, Thanks for the update, I was wondering if the ssl fix that you have put in also has the fix for providing an username password for Redis. Please let us know. |
As far as I know there is no issue with username/password with non-ssl redis. I've used StackStorm connected to redis secured by username/password before quite happily, on many StackStorm versions including 3.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventlet strikes again. 🙄
When connecting to redis SSL via sentinel then 2 problems are encountered:
Therefore when monkey patching SSL library, keep the exception raised on timeout to be socket.timeout.