Add garbage collection for trace and rule_enforcement models #5596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XL
amanda11
changed the title
cognifloyd
approved these changes
Mar 28, 2022
Kami
reviewed
Mar 28, 2022
| @@ -53,6 +53,8 @@ | |||
| "bin/st2-register-content", | |||
| "bin/st2-purge-executions", | |||
| "bin/st2-purge-trigger-instances", | |||
| "bin/st2-purge-trace", | |||
There was a problem hiding this comment.
For consistency it would be good to use plural form of the name here as well - e.g. purge-traces and purge-rule-enforcements.
Kami
reviewed
Mar 28, 2022
| cfg.IntOpt( | ||
| "rule_enforcement_ttl", | ||
| default=None, | ||
| help="Rule enforcements older than this value (days) will be automatically deleted.", |
There was a problem hiding this comment.
May be good to add something along the lines of "Defaults to None aka disabled by default." / "If set to None, it's disabled." to the end of the help strings.
Kami
reviewed
Mar 28, 2022
| @@ -96,6 +96,16 @@ def _register_garbage_collector_opts(ignore_errors=False): | |||
| default=None, | |||
| help="Trigger instances older than this value (days) will be automatically deleted.", | |||
| ), | |||
| cfg.IntOpt( | |||
| "rule_enforcement_ttl", | |||
There was a problem hiding this comment.
Same here, for consistency with the existing naming, the names should be plural.
|
@Kami @cognifloyd i will aim to push a pr to address kami's comments tomorrow, as they were raised after merge. |
amanda11
added a commit
that referenced
this pull request
Mar 30, 2022
This was referenced Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add garbage collection for trace and rule_enforcement models.