Use byte type lock name which is supported by all tooz drivers #5529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
arm4b
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String lock names are not supported by all the tooz drivers because of unsafe encode/decode and concatenation which results in error with string types.
Example:
etcd3gw => https://opendev.org/openstack/tooz/src/branch/master/tooz/drivers/etcd3gw.py#L72
TypeError: can't concat bytes to strmemcached => https://opendev.org/openstack/tooz/src/branch/master/tooz/drivers/memcached.py#L79
TypeError: can't concat bytes to stretcd3 => https://opendev.org/openstack/tooz/src/branch/master/tooz/drivers/etcd3.py#L70
AttributeError: 'str' object has no attribute 'decode'Remaining drivers support both str and byte type
consul => https://opendev.org/openstack/tooz/src/branch/master/tooz/drivers/consul.py#L295
Safe decodeetcd => https://opendev.org/openstack/tooz/src/branch/master/tooz/drivers/etcd.py#L255
Safe encoderedis => https://opendev.org/openstack/tooz/src/branch/master/tooz/drivers/redis.py#L81
Converts to stringzookeeper => https://opendev.org/openstack/tooz/src/branch/master/tooz/drivers/zookeeper.py#L447
Safe decode