-
-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graceful shutdown of action runner. #5428
Merged
cognifloyd
merged 9 commits into
StackStorm:master
from
khushboobhatia01:runner_graceful_shutdown
Jan 18, 2022
Merged
Graceful shutdown of action runner. #5428
cognifloyd
merged 9 commits into
StackStorm:master
from
khushboobhatia01:runner_graceful_shutdown
Jan 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kami
previously requested changes
Nov 11, 2021
d555de7
to
a9a172a
Compare
@Kami Please review the updated changes. |
cognifloyd
reviewed
Dec 3, 2021
cognifloyd
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm really looking forward to using this change in prod.
f11c02c
to
e3da36b
Compare
amanda11
pushed a commit
that referenced
this pull request
Jan 24, 2022
Graceful shutdown of action runner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
service: action runner
size/L
PR that changes 100-499 lines. Requires some effort to review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a wait on runner shutdown for all the ongoing executions to complete.
PR has dependency - #5396
(Ref #5373)