Updates for v3.4.1 #5184
Merged
Updates for v3.4.1 #5184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to troubleshoot locale / encoding related issue. Also make sure we print those version related messages under INFO log level instead of DEBUG since they may be material when troubleshooting various issues so we should use INFO.
infinite loop when trying to format the message field when StackStorm process was not using utf-8 encoding and when unicode sequence was logged.
Co-authored-by: Jacob Floyd <cognifloyd@gmail.com>
pull-request-size
bot
added
the
size/XL
|
CI is failing with: I think it's something new that happened with the upstream GH Actions Docker images and build environment. |
|
On a related note - did you have a chance yet to re-enable the disabled st2tests test and verify it's working now? :) |
|
We may need to update our flake8 settings to make sure they don't conflict with black: # Warn on non utf-8 locale which could cause issues when running under Python 3 and working
# with unicode data
if (
fs_encoding.lower() not in VALID_UTF8_ENCODINGS
or encoding.lower() not in VALID_UTF8_ENCODINGS
):flake8 st2common/st2common/service_setup.py
# st2common/st2common/service_setup.py:163:9: W503 line break before binary operator # Warn on non utf-8 locale which could cause issues when running under Python 3 and working
# with unicode data
if (
fs_encoding.lower() not in VALID_UTF8_ENCODINGS or
encoding.lower() not in VALID_UTF8_ENCODINGS
):flake8 st2common/st2common/service_setup.py
# (okay)
black st2common/st2common/service_setup.py
# reformatted st2common/st2common/service_setup.py
# All done! ✨ 🍰 ✨
# 1 file reformatted.
flake8 st2common/st2common/service_setup.py
# st2common/st2common/service_setup.py:170:9: W503 line break before binary operator |
Kami
approved these changes
Mar 11, 2021
winem
approved these changes
Mar 12, 2021
punkrokk
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls the changes from #5182 into the
v3.4branch.