-
-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "st2 action-alias execute" CLI command #5138
Conversation
There were two bugs: 1. If user it's not specified it will return an error 2. It didn't correctly de-serialize the result so it failed
captured stdout and stderr to display captured stdout + stderr on test failure. This should make troubleshooting those tests much easier and faster.
OK, I couldn't stand not having any tests for such a basic functionality so I also added direct tests in 19e2206 (still not ideal since response is mocked, but that's the pattern we use for CLI tests :/). I also pushed a small related improvements which such make troubleshooting CLI tests easier - 75a114c. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. I didn't know about st2 action-alias execute
. Awesome.
Fixes and tests lgtm
I'm also working on related functionality - |
I tried to use StackStorm after quite a long time and in the first 5 minutes I encountered two exceptions / bugs (like in the good old days - guess I'm always the "lucky" one :D).
There are two bugs in
st2 action-alias execute
command so it doesn't work.user
query param is not specified, it will fail with the error below due to API returning an error due to type mismatch (out of the box behavior with st2-docker).match_and_execute
API operation is not correctly de-serialized in the client so client returns empty object and the code throws an exception. API returns a container object with a list so we need to handle that correctly.This PR fixes both issues.
TODO