-
-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue 4998 - Web Hook Rules check http headers in case sensitive manner #5038
Conversation
Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically marking is as stale. If this issue is not relevant or applicable anymore (problem has been fixed in a new version or similar), please close the issue or let us know so we can close it. On the contrary, if the issue is still relevant, there is nothing you need to do, but if you have any additional details or context which would help us when working on this issue, please include it as a comment to this issue. |
FYI: we just merged a change that reformats all the code with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rand01ph could you please sign the CLA? (If you signed it before, you'll need to resign it now that it says "Linux Foundation" instead of one of the previous StackStorm stewards).
Also, I just resolved the conflicts, merged master into your branch, and reformatted with black.
I have one style suggestion.
I would like to merge your PR fairly quickly if you can help me at least with the CLA. Hopefully there's not much left before we can merge this.
Co-authored-by: Jacob Floyd <cognifloyd@gmail.com>
Merged! Thanks, everyone! 👍 |
I have add a payload['headers_lower'] for webhook and add a unittest for this.
Fixes #4998