Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinning pip to 20.0.2 to fix build issues introduced in pip 20.1 #4929

Merged
merged 3 commits into from
May 1, 2020
Merged

Pinning pip to 20.0.2 to fix build issues introduced in pip 20.1 #4929

merged 3 commits into from
May 1, 2020

Conversation

nmaludy
Copy link
Member

@nmaludy nmaludy commented Apr 29, 2020

Recently pip release 20.1 and broke our dist_utils.py in many of our components.
Since we weren't pinning pip this caused builds to fail.

This PR pins pip to 20.0.2 and setuptools to 44.1.0 until we can roll out a proper fix for all of the dist_utils.py across our organization.

Related:

@nmaludy nmaludy added the bug label Apr 29, 2020
@nmaludy nmaludy requested review from Kami, blag and arm4b April 29, 2020 18:54
@nmaludy nmaludy self-assigned this Apr 29, 2020
@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Apr 29, 2020
@nmaludy nmaludy added this to the 3.3.0 milestone Apr 29, 2020
arm4b
arm4b approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

These kind of issues appear right when you don't wait them, during the 3.2.0 release process.
Thanks for the help with hotfix unblocking the release!

This was referenced Apr 29, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines. Very easy to review. and removed size/XS PR that changes 0-9 lines. Quick fix/merge. labels Apr 29, 2020
arm4b
arm4b approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hotfixes! 👍

@arm4b arm4b merged commit 268d94f into master May 1, 2020
@arm4b arm4b deleted the hotfix/pin-pip-setuptools branch May 1, 2020 15:59
@blag blag mentioned this pull request May 5, 2020
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b approved these changes

@Kami Kami Awaiting requested review from Kami

@blag blag Awaiting requested review from blag

Assignees

@nmaludy nmaludy

Labels
bug size/S PR that changes 10-29 lines. Very easy to review.
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nmaludy @arm4b