Various changes and fixes which make StackStorm code more re-usable in different contexts #4713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is no sudo binary available.
This way we can use either eventlet or gevent, depending on the application (e.g. gRPC doesn't support eventlet so we need to use gevent). Also fix a bug with where we set returncode on the process. If we set it before calling kill() it will get overwritten inside kill() method.
action fails before producing any output.
are not git repositories (think contrib/core).
m4dcoder
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains various changes and fixes which makes StackStorm code more re-usable in different context (think Docker, etc.).
Fix requirements.txt files so they contain all the dependency which are needed. This way
st2-pack-*CLI commands work correctly out of the box in a standalone manner (in situation where only st2common is installed.Update list of scripts defined in
st2common/setup.py(list was out of date, missing some scripts and containing some old ones).Update
move_packfunction so it works in Docker and other environments wheresudois not available.Add new
get_runner_moduleutility method which reduces code duplication.Fix a bug with timeout handling in the Python runner. If action failed before producing any output (stdout, stderr) Python runner would fail on parsing the action output.
There was also an issue related to how we set
process.returncode. We set it before callingprocess.kill()which means that in some scenarios,process.kill()would overwrite this code.Make concurrency model for
st2common.util.green.*modules pluggable. This way eithereventletorgeventcan be used for functions in that package.This is important because there are scenarios where eventlet doesn't' work (e.g. gRPC supports
gevenet, but noteventlet).Upgrade
toozto1.65.0since older version depends on old version ofgrpciowhich causes conflicts with other libraries which depend on newer versions ofgrpcioUpdate
st2-pack-installCLI command so it supports installing local packs which are not git repositories.