Consistent register content during 'pack install' #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm4b
force-pushed
the
fix/register-content-consistency
branch
from
c069abe to
a5aa6ed
Compare
|
Thanks. I'm fine with that change - I originally left is so it only registered this content type because that's what happened in the past (pre-content management). Let's please also add a changelog entry. |
Kami
approved these changes
Jun 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3445
The problem with the current approach is that
st2ctl reload&st2 pack install&st2 pack registerregister different type of content by default, leading to confusion and error-prone scenarios when you got different functionality working for a pack, depending on situation.With this PR we register
allavailable content in pack by default during thest2 pack install.This is already default behavior for
st2 pack register, - follow that.