Add tags support in trigger API #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tom thanks for the patch! once travis is happy someone will take a look. We are in prep for a major release so if response is some what delayed, thanks for patience. Cheers, DZ. |
| @@ -313,13 +314,16 @@ def _add_trigger_models(trigger_type): | |||
| payload_schema = trigger_type['payload_schema'] if 'payload_schema' in trigger_type else {} | |||
| parameters_schema = trigger_type['parameters_schema'] \ | |||
| if 'parameters_schema' in trigger_type else {} | |||
| tags = trigger_type['tags'] \ | |||
There was a problem hiding this comment.
You could also do tags = trigger_type.get('tags', {}) :)
|
Thanks. LGTM. |
|
Added some tests in deec8f4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrieving triggers using st2 trigger get, no tags where shown even though they were define in the sensor yaml file. With these changes tags for triggers are properly stored when registering sensors.