-
-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
St2Stream service broken when using SSL with mongodb #5078
Comments
Thanks for the report! Considering there is an example PR to fix it for other services, we'd love to accept external contributions to fix this for str2stream as well. Help wanted. |
What line did you put the monkey patch in? |
Hey, I added the line just below the copyright st2/st2stream/st2stream/cmd/api.py Line 15 in ce31176 from st2common.util.monkey_patch import monkey_patch |
@Christopher-Russell should be easy to submit a PR then. Can you do it? |
No worries, I'll submit a PR |
I've submitted in #5091 |
ticket #5078 fix: Resolves issue where st2stream crashes with a max depth error when connecting to a mongodb via SSL
SUMMARY
This issue is an extension to #4832 however this time it is the st2stream service, I have looked that the code and can see the same monkey patch code hasn't been applied to the st2stream app
STACKSTORM VERSION
Paste the output of
st2 --version
: 3.3.0OS, environment, install method
Docker compose with the split services and mongo db references commented out so that an external db can be used https://github.com/StackStorm/st2-docker/blob/master/docker-compose.yml
All other services correctly connected to mongodb.net test instance with the exception of st2stream.
Steps to reproduce the problem
use docker yaml at https://github.com/StackStorm/st2-docker/blob/master/docker-compose.yml, comment out mongo container and references, adjust files/st2-docker.conf to point to external DB with SSL = True enabled.
docker-compose up
Expected Results
What did you expect to happen when running the steps above?
st2stream to operate correctly
Actual Results
What happened? What output did you get?
2020-11-16 05:48:55,053 WARNING [-] Retry on ConnectionError - Cannot connect to database default :
maximum recursion depth exceeded
Adding monkey patch code to st2stream app resolves the issue (manually injected into container to test).
file: st2stream/cmd/api.py
Code:
from st2common.util.monkey_patch import monkey_patch
monkey_patch()
The text was updated successfully, but these errors were encountered: