-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch CI from Circle to GitHub #250
Conversation
@mamercad This is really nice work here! |
I added |
I'm participating in Hacktoberfest, so, if you wouldn't mind adding the |
...and here's the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot!
Still wondering why GH Actions didn't start here 🤔
Can't see any setting that would block it.
Thanks @mamercad, that worked after merging! I just spot another issue when the build reports success while having failure in the tests, if you'd like to take a quick look at that too: CI build reports success on failed tests #251 |
...taking a look. |
Switch CI from Circle to GitHub; you can see a run at my fork. Looks like my IDE also trimmed some whitespace in the
README.md
, let me know if that's a problem.