Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CI from Circle to GitHub #250

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Switch CI from Circle to GitHub #250

merged 3 commits into from
Oct 5, 2022

Conversation

mamercad
Copy link
Contributor

@mamercad mamercad commented Oct 4, 2022

Switch CI from Circle to GitHub; you can see a run at my fork. Looks like my IDE also trimmed some whitespace in the README.md, let me know if that's a problem.

@arm4b
Copy link
Member

arm4b commented Oct 4, 2022

@mamercad This is really nice work here!
I left one comment guessing why the GH Actions didn't run for this PR.

@mamercad
Copy link
Contributor Author

mamercad commented Oct 4, 2022

I added on.workflow_dispatch in case you'd like to trigger it manually as well.

@mamercad mamercad requested a review from arm4b October 4, 2022 17:22
@mamercad
Copy link
Contributor Author

mamercad commented Oct 4, 2022

Just dropped a PR for st2-auth-ldap if you're a maintain there as well @armab.

@mamercad
Copy link
Contributor Author

mamercad commented Oct 4, 2022

I'm participating in Hacktoberfest, so, if you wouldn't mind adding the hacktoberfest-accepted label, I'd appreciate it.

@mamercad
Copy link
Contributor Author

mamercad commented Oct 4, 2022

...and here's the st2-rbac-backend one.

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot!

Still wondering why GH Actions didn't start here 🤔
Can't see any setting that would block it.

@arm4b arm4b merged commit 9609a00 into StackStorm:master Oct 5, 2022
@arm4b
Copy link
Member

arm4b commented Oct 5, 2022

Thanks @mamercad, that worked after merging!

I just spot another issue when the build reports success while having failure in the tests, if you'd like to take a quick look at that too: CI build reports success on failed tests #251

@mamercad mamercad deleted the github branch October 5, 2022 11:53
@mamercad
Copy link
Contributor Author

mamercad commented Oct 5, 2022

Thanks @mamercad, that worked after merging!

I just spot another issue when the build reports success while having failure in the tests, if you'd like to take a quick look at that too: CI build reports success on failed tests #251

...taking a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants