Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting all the things #326

Closed
wants to merge 5 commits into from

Conversation

mamercad
Copy link
Contributor

@mamercad mamercad commented Dec 5, 2022

Currently, on master, this is what the summary looks like:

                              Rule Violation Summary                              
 count tag                    profile    rule associated tags                     
    13 jinja[spacing]         basic      formatting (warning)                     
    12 role-name              basic      deprecations, metadata (warning)         
    12 schema[meta]           basic      core, experimental (warning)             
     3 name[missing]          basic      idiom                                    
     5 name[template]         moderate   idiom                                    
    43 name[casing]           moderate   idiom (warning)                          
    26 risky-file-permissions safety     unpredictability, experimental (warning) 
     4 ignore-errors          shared     unpredictability, experimental (warning) 
     1 meta-no-tags           shared     metadata                                 
   162 fqcn[action-core]      production formatting                               
    19 fqcn[action]           production formatting (warning)                     

Failed after min profile: 171 failure(s), 129 warning(s) on 106 files.

On this branch, the summary looks like this:

                        Rule Violation Summary                        
 count tag           profile rule associated tags                     
    12 role-name     basic   deprecations, metadata (warning)         
     1 ignore-errors shared  unpredictability, experimental (warning)

@pull-request-size pull-request-size bot added the size/XXL PR that changes 1000+ lines. You should absolutely split your PR into several. label Dec 5, 2022
@arm4b
Copy link
Member

arm4b commented Dec 5, 2022

Setting the breaking change tag here, if we want to update the min ansible version and more following that.

Sounds like it can also close the #242 ?

@mamercad
Copy link
Contributor Author

mamercad commented Dec 5, 2022

Setting the breaking change tag here, if we want to update the min ansible version and more following that.

Sounds like it can also close the #242 ?

Yep, I think so, we should strive for at least ansible-core 2.13 (that gives us about a year of security and bug fixes).

@mamercad
Copy link
Contributor Author

mamercad commented Jan 5, 2023

Closed in favor of ansible-lint --write down the road.

@mamercad mamercad closed this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement size/XXL PR that changes 1000+ lines. You should absolutely split your PR into several.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants