Drop U16 and add U20 support

[winem]

This PR drops the support for Ubuntu 16 (xenial) and adds support for Ubuntu 20 (focal).

In addition this PR also adds meta/main.yml files for the redis and smoketests role which weren't there yet. This is rather a matter of consistency than of functionality but it seems a good chance to get this done.

It also removes support for MongoDB-Versions that are already EoL as there are 3.2 and 3.4.

Tests with st2repo_name = unstable were successful.

[arm4b]

Looks like we'll also need to add U20 to CI, per https://travis-ci.org/github/StackStorm/ansible-st2/builds/773942784 list

[cognifloyd]

I have few minor changes and questions.

[amanda11]

As well as the comment on mongo 4.2, I think we also need updates on:

• .kitchen.yml - has ubuntu 16 still
• .travis.yml

[winem]

Will update the ci files (travis, kitchen, etc.) till tomorrow evening.

[cognifloyd]

mongodb_version needs to change for debian 20. You added an extra vars file and tasks to load that. I think it would be cleaner to consolidate the version choice in the defaults file, which looks like:

ansible-st2/roles/StackStorm.mongodb/defaults/main.yml

Lines 2 to 3 in 94e3c4f

	# MongoDB default version
	mongodb_version: "4.0"

But you could do this:

 # MongoDB default version
-mongodb_version: "4.0" 
+mongodb_version: "{% if ansible_facts.os_family == 'Debian' and ansible_facts.distribution_major_version == '20' %}4.4{% else %}4.0{% endif %}" 

[winem]

mongodb_version needs to change for debian 20. You added an extra vars file and tasks to load that. I think it would be cleaner to consolidate the version choice in the defaults file, which looks like:

ansible-st2/roles/StackStorm.mongodb/defaults/main.yml

Lines 2 to 3 in 94e3c4f

	# MongoDB default version
	mongodb_version: "4.0"

But you could do this:

 # MongoDB default version
-mongodb_version: "4.0" 
+mongodb_version: "{% if ansible_facts.os_family == 'Debian' and ansible_facts.distribution_major_version == '20' %}4.4{% else %}4.0{% endif %}" 

I did it like that now. Guess that's the smartest solution to the issue and does not break with any common pattern or best practices.

[amanda11]

LGTM - but wait for those others that gave review comments to give their approval.

[cognifloyd]

LGTM

[amanda11]

Need to remove ubuntu-20 from here. We can't run it as a stable run yet until 3.5 is released.
So we need to do the changes for ansible-st2 in 2 stages.

1. add it to unstable before release - under this PR
2. add it to stable after release - separate PR

[arm4b]

I think we'll just have to wait for a release to happen before merging this PR.

Otherwise, someone using the fresh Ansible installer will have the same issues with U16/U20.

[rush-skills]

To decide between 4.0 and 4.4 mongo version, wouldn't it be a better idea to use st2 version > 3.4 rather than only on Ubuntu 20?

[amanda11]

@rush-skills Stackstorm 3.5 still uses mongo 4.0 for all OSes EXCEPT for Ubuntu 20

[arm4b]

👍
Following the #Ansible community messages, we want to merge it ASAP, considering the 3.5.0 release is ready.

Just migrated repo to the new TravisCI.com to get the build finished.

[arm4b]

All green, great work everyone!