Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure st2.conf values are not converted to particular structure #234

Merged
merged 2 commits into from
Apr 8, 2019

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Apr 6, 2019

Closes #238

Covers edge case when user wants to set in st2.conf json-formatted value which might be converted to particular structure during the jinja/ansible pipeline.

See #156

Covers edge case when user wants to set in st2.conf json-formatted value which might be converted to particular structure during the jinja/ansible pipeline
@Kami
Copy link
Member

Kami commented Apr 8, 2019

LGTM.

How hard would it be to add tests for it?

@arm4b
Copy link
Member Author

arm4b commented Apr 8, 2019

That would be not that easy and bring insufficient value comparing to increasing the build timing and tests complexity.
Ansible plays we have are designed to be simple and have only smoke tests instead of checking all the permutations of possible configurations. It's the best effort we can do and is good enough, considering ongoing development/maintenance of many other projects.

@arm4b arm4b merged commit 19a8088 into master Apr 8, 2019
@arm4b arm4b deleted the enhancement/st2.conf-setting branch April 8, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants