New linting rules #221
Merged
New linting rules #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
requested changes
Dec 19, 2018
arm4b
reviewed
Dec 19, 2018
arm4b
reviewed
Dec 19, 2018
Co-Authored-By: LindsayHill <lindsay.k.hill@gmail.com>
Co-Authored-By: LindsayHill <lindsay.k.hill@gmail.com>
Co-Authored-By: LindsayHill <lindsay.k.hill@gmail.com>
arm4b
approved these changes
Dec 20, 2018
|
Thanks for the input both of you. Have merged your suggestions. Now just have to wait for Travis to do its thing. Assuming all is well, I will then merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ansible-lint4.0.0 introduces many new default rules. These trip us up in many places.The only new default rule I have not fixed is the 120-char line length rule. For now I have just excluded that rule from checks.
I have also fixed a small issue with our CircleCi config, where it was running ansible-lint against non-existent
*.yamlfiles.