Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added st2workflowengine #198

Merged

Conversation

nmaludy
Copy link
Member

@nmaludy nmaludy commented Jul 10, 2018

Closes #196
Added st2workflowengine to the list of services for 2.8.0 release

@Kami
Copy link
Member

Kami commented Jul 11, 2018

LGTM.

Do we need any other changes to support this new service? Or is this it?

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should be enough, since the st2_services list is referenced in other places like

- name: restart st2
become: yes
service:
name: "{{ item }}"
state: restarted
with_items: "{{ st2_services }}"
and
- name: Ensure StackStorm services are enabled and running
become: yes
service:
name: "{{ item }}"
enabled: yes
state: started
with_items: "{{ st2_services }}"
tags: st2

@arm4b arm4b added the feature label Jul 11, 2018
@arm4b arm4b merged commit 60b1527 into StackStorm:master Jul 11, 2018
@arm4b
Copy link
Member

arm4b commented Jul 11, 2018

Thanks again for PR! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants