Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional url #12

Merged
merged 3 commits into from
Mar 14, 2021
Merged

Optional url #12

merged 3 commits into from
Mar 14, 2021

Conversation

nzlosh
Copy link
Contributor

@nzlosh nzlosh commented Oct 7, 2020

Make url parameter optional for actions.

  • Updated changelog
  • Bumped pack version
  • Updated readme documentation

README.md Outdated Show resolved Hide resolved
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I left several comments to address.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@nzlosh
Copy link
Contributor Author

nzlosh commented Mar 13, 2021

I've bump the version of the pack to 2.0.0 to reflect the breaking change for existing actions.

Copy link
Contributor Author

@nzlosh nzlosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@armab Did you have any further comments on this or can we mark it as resolved?

actions/targets.py Show resolved Hide resolved
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks!

@arm4b arm4b merged commit 2e4552a into StackStorm-Exchange:master Mar 14, 2021
@arm4b
Copy link
Member

arm4b commented Mar 14, 2021

@nzlosh Thanks for the contribution!

Are you frequently using this pack and interested in maintaining it further?

We'll need something like this with the Codeowners file: StackStorm-Exchange/exchange-incubator#152 (comment) If interested, I'd welcome you to open a PR then.

@nzlosh nzlosh deleted the optional_url branch March 14, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants