-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional url #12
Optional url #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I left several comments to address.
I've bump the version of the pack to 2.0.0 to reflect the breaking change for existing actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@armab Did you have any further comments on this or can we mark it as resolved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks!
@nzlosh Thanks for the contribution! Are you frequently using this pack and interested in maintaining it further? We'll need something like this with the Codeowners file: StackStorm-Exchange/exchange-incubator#152 (comment) If interested, I'd welcome you to open a PR then. |
Make
url
parameter optional for actions.