update python version as list #145
Conversation
|
Changing this requires coordinating changes across two more repos. edit: I guess the incubator change is not needed for this PR. |
|
@cognifloyd @armab created a draft PR for stackstorm-git repo. Please let me know if the syntax is correct. |
There was a problem hiding this comment.
Dang. This CI run shows that there's something wrong:
https://github.com/StackStorm-Exchange/stackstorm-git/actions/runs/7089455034
| @@ -14,7 +14,7 @@ on: | |||
| python-version: | |||
| required: false | |||
| type: string | |||
| default: "3.6" | |||
| default: ["3.6","3.8","3.9"] | |||
There was a problem hiding this comment.
This is now an array, not a string, but GHA only allows boolean, number, or string for input types:
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onworkflow_callinputsinput_idtype
So, we probably need to pass a json array in as a string, and then use the fromJSON function below.
| default: ["3.6","3.8","3.9"] | |
| default: '["3.6","3.8","3.9"]' |
| name: 'Python ${{ matrix.python-version }}' | ||
| strategy: | ||
| matrix: | ||
| include: | ||
| - python-version: ${{ inputs.python-version }} | ||
| python-version: ${{ inputs.python-version }} |
There was a problem hiding this comment.
Since the input has to be a string, we need fromJSON here:
https://docs.github.com/en/actions/learn-github-actions/expressions#fromjson
| python-version: ${{ inputs.python-version }} | |
| python-version: ${{ fromJSON(inputs.python-version) }} |
|
@cognifloyd Thanks for reviewing. Made the suggested changes. |
|
@cognifloyd looks like build got triggered for python 3.8 and python 3.9 as expected StackStorm-Exchange/stackstorm-git#15 |
|
Thanks @sravs-dev and @cognifloyd ! |
No description provided.