Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add Python 3.8 to testing #138

Closed
wants to merge 2 commits into from
Closed

CI: Add Python 3.8 to testing #138

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
084d48b
Add python38
mamercad Dec 18, 2022
0a40302
Update the comment
mamercad Dec 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/pack-build_and_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,20 +35,24 @@ jobs:
build_and_test:
runs-on: ubuntu-20.04
# When parent workflow is named "Build and Test" this shows up as:
# "Build and Test / Python 3.6"
# "Build and Test / Python 3.X"
name: 'Python ${{ matrix.python-version-short }}'
strategy:
fail-fast: false
max-parallel: 2
matrix:
include:
- python-version-short: "3.6"
python-version: 3.6.13
- python-version-short: "3.8"
python-version: 3.8.10
Comment on lines +47 to +48
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍 to include 3.8 in the matrix.

@cognifloyd Is there anything else we need to handle for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few repos that will also need an update I believe. I'll look at which when I'm at my computer later today.

steps:
- name: Checkout Pack Repo and CI Repos
uses: StackStorm-Exchange/ci/.github/actions/checkout@master
with:
st2-branch: ${{ inputs.st2-branch }}
lint-configs-branch: ${{ inputs.lint-configs-branch }}

- name: Install APT Dependencies
uses: StackStorm-Exchange/ci/.github/actions/apt-dependencies@master
with:
Expand Down