Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to ci/gha #117

Closed
wants to merge 101 commits into from
Closed

Updates to ci/gha #117

wants to merge 101 commits into from

Conversation

lm-ydubler
Copy link
Contributor

This PR includes updates to various files in the gha branch in order to convert the incubator to GHA & get it up and running.


- name: Install StackStorm requirements
# this should run in the st2 checkout
shell: bash
working-directory: st2
env:
VIRTUALENV_DIR: "~/virtualenv"
Copy link
Member

@cognifloyd cognifloyd Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Since tilde expansion isn't happening like I thought, so maybe we can do this instead:

Suggested change
VIRTUALENV_DIR: "~/virtualenv"
VIRTUALENV_DIR: ${{ env.HOME }}/virtualenv

To do that, we need to add a step at the beginning of the job like this:

- name: add HOME to env context
  shell: bash
  run: echo ::set-env name=HOME::$HOME

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed this into change to the upstream gha branch.

# TODO: This Makefile has CircleCI assumptions
run: |
cp ${ACTION_PATH}/../../.circle/Makefile .
cp ${{env.ACTION_PATH}}/../../.circle/Makefile .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out, github already exposes action_path as an env var, so we can remove ACTION_PATH from the env block and just use $GITHUB_ACTION_PATH

Suggested change
cp ${{env.ACTION_PATH}}/../../.circle/Makefile .
cp ${GITHUB_ACTION_PATH}/../../.circle/Makefile .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed this to the upstream gha branch

@cognifloyd
Copy link
Member

@lm-ydubler I just consolidated a bunch of the changes into the gha branch. Could you merge that into your gha branch to reduce the diff?

@arm4b
Copy link
Member

arm4b commented Nov 25, 2021

Thanks, folks for the work you're doing 👍

To connect the dots, just left some notes on the Proposal: Use Github Actions for StackStorm-Exchange CI and Maintenance #63 which is relevant to this PR.

@cognifloyd
Copy link
Member

OK. The build_and_test workflow is good to go on the gha branch. I'm going to close this PR now. We'll open up another PR for any collaboration on the deploy workflow, and then one final PR to merge the gha branch into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants