Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AXFRDDNS: Enable automated testing #3290

Merged
merged 8 commits into from
Jan 1, 2025
Merged

AXFRDDNS: Enable automated testing #3290

merged 8 commits into from
Jan 1, 2025

Conversation

tlimoncelli
Copy link
Contributor

@tlimoncelli tlimoncelli commented Jan 1, 2025

Fixes #3279

Issue

  • Add AXFRDDNS and AXFRDDNS_DNSSEC to the list of automated tests
  • integration_test.go doesn't handle testing the same provider twice with different inputs
  • AXFRDDNS shouldn't warn about "buggy-cname" setting.

Resolution

  • integration_test.go: permit providers.json to list the same provider multiple times; as long as they all set the TYPE correctly
  • providers.json: Add AXFRDDNS_DNSSEC stanza
  • axfrddnsProvider.go: Add missing field to initAxfrDdns

@tlimoncelli
Copy link
Contributor Author

CC gucci-on-fleek

@tlimoncelli
Copy link
Contributor Author

It turns out the integration tests don't accept 2 profiles with the same provider. I hacked around a bit to make it work.

@tlimoncelli tlimoncelli merged commit 9c3a161 into main Jan 1, 2025
20 checks passed
@tlimoncelli tlimoncelli deleted the tlim_3279_axfrddns branch January 1, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AXFRDDNS to automated tests
2 participants