CICD: Update docs/comments after file renames #3278
Conversation
These testcases are already in the "TXT backslashes" testgroup.
This file was recently renamed from pr_test.yml but some references to pr_test.yml still existed.
There was a problem hiding this comment.
Thank you, @tomfitzhenry, for your contribution! 🎉 You’ve given the documentation a great touch-up by fixing those small imperfections. It’s these little details that really make everything shine. 👌🚀
|
Glad to hear it! :) |
| @@ -1263,12 +1263,6 @@ func makeTests() []*TestGroup { | |||
| // Vultr syntax-checks TXT records with SPF contents. | |||
| tc("Create a TXT/SPF", txt("foo", "v=spf1 ip4:99.99.99.99 -all")), | |||
|
|
|||
| // Nobody needs this and many APIs don't allow it. | |||
There was a problem hiding this comment.
Why remove this? I think the comment "Nobody needs this" was sarcasm. If an API doesn't allow it, the auditrecords.go file should indicate if this needs to be skipped.
There was a problem hiding this comment.
These testcases are already in the "TXT backslashes" testgroup.
(I put the justification in the commit message, but I know that's not very visible during review: 90929fe )
There was a problem hiding this comment.
AH, now I see! I really shouldn't do reviews from my phone :)
tlimoncelli
changed the title
Here's some small fixes for things I noticed while doing #3277 .
I raised these in a separate PR so they're easier to review.
Descriptions for each fix in the commit messages.