Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cannot() records for Azure and R53 ALIAS records #1827

Merged

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Nov 29, 2022

It was confusing to me that most services had a “-” in the table for R53_ALIAS and AZURE_ALIAS while some had an “X.” I’ve removed the Cannot() calls for the corresponding capabilities from the providers that had them since it will never make sense for another provider to support these record types.

@j-f1
Copy link
Contributor Author

j-f1 commented Nov 29, 2022

Now that I think about this a bit more, would it make sense to entirely get rid of the rows for those record types? They really are only applicable to the one provider and people could find out that they’re supported by browsing the pages for each provider separately. R53 and Azure could also be updated to show support for the ALIAS record type with a tooltip indicating you have to use the custom one.

Relatedly, should support for the URL type be added as a row? It looks like more providers than Namecheap support it.

@tlimoncelli
Copy link
Contributor

I agree that R53_ALIAS and AZURE_ALIAS make the chart look ugly. However they should be listed somewhere. Maybe a bullet list of provider-specific types?

As far as URL... different providers implement that kind of thing differently. We probably should have called that NAMECHEAP_URL. My preference is to have GENERIC_REDIRECT() that supports a lowest-common-denominator redirect that "does the right thing" for each provider. (maybe flags for 301 vs 301 redirects but nothing else).

@tlimoncelli tlimoncelli merged commit cc2fb89 into StackExchange:master Dec 2, 2022
@j-f1 j-f1 deleted the remove-unnecessary-unsupported branch December 2, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants