feat(providers): add netlify

[SphericalKat]

Closes #714

[tlimoncelli]

Looks good so far!

Just FYI: It is normal for tests to fail as "unauthorized". Github won't provide API keys to PRs that come from outside.

Let me know when its ready for for review.

[SphericalKat]

Hello, this is ready for review. Thanks!

[msfjarvis]

Found a couple issues while testing this out

1. Netlify's NETLIFY and NETLIFYv6 records are not supported but definitely should be
2. TXT records are currently broken, but that's a quick fix

diff --git providers/netlify/netlifyProvider.go providers/netlify/netlifyProvider.go
index 2752274fd229..4bdfb6580965 100644
--- providers/netlify/netlifyProvider.go
+++ providers/netlify/netlifyProvider.go
@@ -116,7 +116,7 @@ func (n *netlifyProvider) GetZoneRecords(domain string) (models.Records, error)
 			}
 			err = rec.SetTargetSRV(uint16(r.Priority), r.Weight, r.Port, r.Value)
 		case "TXT":
-			err = rec.SetTargetTXTfromRFC1035Quoted(r.Value)
+			err = rec.SetTargetTXT(r.Value)
 		case "CAA":
 			err = rec.SetTargetCAA(uint8(r.Flag), r.Tag, r.Value)
 		default:

[SphericalKat]

Thanks for the report @msfjarvis, working on these issues.

[SphericalKat]

Hello, I've been working with @msfjarvis to fix the issues he reported. The TXT records issue has been fixed, but NETLIFY records seem to be rather painful. Through a bit of experimentation, it's clear that the Netlify API does not allow for manual creation of these records.

One option is just to transparently ignore them, but I'm open to other suggestions. Your advice would be very welcome @tlimoncelli 😄

[tlimoncelli]

I concur. Let's break this into 2 merges. The first will ignore NETLIFY records. Then work out how to handle them in a second merge.

[abovedave]

It seems like NETLIFY records are special in the sense they are created/updated at the site level within the Netlify UI (for features like branch subdomains).

Perhaps it's worth exploring the updateSite endpoint?

[msfjarvis]

Likely unsuitable to be merged into the PR, but with this diff applied I've been able to use IGNORE_NAME to suppress the unwanted deletion of the NETLIFY records.

D('msfjarvis.dev', NewRegistrar('none'), DnsProvider(NewDnsProvider('netlify')),
  IGNORE_NAME('*', 'NETLIFY'),
  IGNORE_NAME('*', 'NETLIFYv6'),
);

[abovedave]

Been thinking about this some more, as NETLIFY records are handled automatically when you create or delete sites, push branches etc, is there even as use case for modifying them through DNSControl?

I'm think the solution might be just transparently ignore as suggested.

[tlimoncelli]

@abovedave Oh! That makes a lot of sense!

[tlimoncelli]

As far as the code is concerned, this all looks great! No suggestions.

I won't merge it until I hear from you about ignoring the NETLIFY records, etc.

[SphericalKat]

Hey, just got back to work on this. No, we don't need NETLIFY stuff in the helpers; I'll remove those and modify the provider to ignore NETLIFY records in a moment.

[msfjarvis]

Verified that the provider correctly skips the NETLIFY and NETLIFYv6 rtypes for my site

[tlimoncelli]

Thank you for the contribution! A lot of people have asked for this!

[SphericalKat]

Cheers!

[j-f1]

Thanks for adding this! Can you add a clarification to the docs about why someone would want to provide (or not provide) an account slug?

[j-f1]

@SphericalKat Not sure if you saw my comment above but it was a minor point of confusion as I was setting up my Netlify configuration ^