NEW PROVIDER: Gcore DNS #1816
Merged
NEW PROVIDER: Gcore DNS #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlimoncelli
reviewed
Nov 15, 2022
providers/gcore/convert.go
Outdated
| switch recType { | ||
| case "CAA": // G-Core API don't need quotes around CAA with whitespace | ||
| if len(value.Content) != 3 { | ||
| panic("incorrect number of fields in G-Core's CAA record") |
There was a problem hiding this comment.
Please return an error instead of calling panic().
providers/gcore/convert.go
Outdated
|
|
||
| flag, tag, target := parts[0], parts[1], parts[2] | ||
| if err := rc.SetTargetCAAStrings(flag, tag, target); err != nil { | ||
| panic(fmt.Errorf("unparsable record received from G-Core: %w", err)) |
There was a problem hiding this comment.
Please return an error instead of calling panic().
providers/gcore/convert.go
Outdated
|
|
||
| default: // "A", "AAAA", "CAA", "NS", "CNAME", "MX", "PTR", "SRV", "TXT" | ||
| if err := rc.PopulateFromString(recType, value.ContentToString(), zoneName); err != nil { | ||
| panic(fmt.Errorf("unparsable record received from G-Core: %w", err)) |
There was a problem hiding this comment.
Please return an error instead of calling panic().
|
Thanks for your feedback! That has been fixed. |
|
Excellent! Thanks for the contribution! It's always a pleasure to get a new provider added to the project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Gcore DNS (https://gcore.com/dns) using their Golang SDK.
Code is based on deSEC provider, since Gcore performs incremental-label-type updates.
Passes all integration tests, and tested on my own domain.