Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(badge): add ai variant #1853

Merged
merged 4 commits into from
Nov 13, 2024
Merged

feat(badge): add ai variant #1853

merged 4 commits into from
Nov 13, 2024

Conversation

dancormier
Copy link
Contributor

@dancormier dancormier commented Nov 6, 2024

STACKS-686

This PR adds AI and bot variants to the badge component. See also Figma.

Testing

Screenshots

Light

image

Light high contrast

image

Dark

image

Dark high contrast

image


Original PR description from Nov 6, 2024: Since the request for an AI badge seems urgent, I went ahead and implemented it in this PR so we could quickly merge and ship if we decide this is the correct course. If we decide against including this in Stacks, I'm glad to junk this PR and lift the useful parts out into Core (or wherever they're needed).

@dancormier dancormier added the do-not-merge Pull requests that are in progress and should not be merged yet label Nov 6, 2024
@dancormier dancormier requested review from CGuindon and giamir November 6, 2024 20:15
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for stacks failed. Why did it fail? →

Name Link
🔨 Latest commit 64e87fd
🔍 Latest deploy log https://app.netlify.com/sites/stacks/deploys/672cf201dcd74800086c88a8

@dancormier dancormier marked this pull request as ready for review November 7, 2024 16:57
Copy link
Collaborator

@CGuindon CGuindon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dancormier dancormier removed the do-not-merge Pull requests that are in progress and should not be merged yet label Nov 12, 2024
@dancormier
Copy link
Contributor Author

@giamir I'm gonna merge this so I can cut a release and get started integrating. Let me know if you find any issues and I'll fix it ASAP

@dancormier dancormier merged commit 5599a51 into develop Nov 13, 2024
7 of 11 checks passed
@dancormier dancormier deleted the STACKS-686/ai-badges branch November 13, 2024 17:57
@giamir
Copy link
Contributor

giamir commented Nov 14, 2024

Looks good @dancormier. Thanks.
Sorry for the delay, I thought I already reviewed this one but I confused it with the previous spike PR you made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants